Skip to content

Fix error / warning messages #6594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Dec 31, 2025
Merged

Fix error / warning messages #6594

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e762c78
fix functools.partial repr
youknowone Dec 30, 2025
562bea3
warn_deprecated_throw_signature
youknowone Dec 30, 2025
60f5185
fix function error messages
youknowone Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix functools.partial repr
  • Loading branch information
@youknowone
youknowone committed Dec 31, 2025
commit e762c78f61ad85670fe9d79c9358534d593d843d
2 changes: 0 additions & 2 deletions Lib/test/test_functools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,11 +465,9 @@ def __str__(self):
self.assertIn('astr', r)
self.assertIn("['sth']", r)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_repr(self):
return super().test_repr()

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_recursive_repr(self):
return super().test_recursive_repr()

Expand Down
32 changes: 13 additions & 19 deletions crates/vm/src/stdlib/functools.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ mod _functools {
}

#[pyattr]
#[pyclass(name = "partial", module = "_functools")]
#[pyclass(name = "partial", module = "functools")]
#[derive(Debug, PyPayload)]
pub struct PyPartial {
inner: PyRwLock<PyPartialInner>,
Expand Down Expand Up @@ -319,28 +319,22 @@ mod _functools {
));
}

let class_name = zelf.class().name();
let qualname = zelf.class().__qualname__(vm);
let qualname_str = qualname
.downcast::<crate::builtins::PyStr>()
.map(|s| s.as_str().to_owned())
.unwrap_or_else(|_| zelf.class().name().to_owned());
let module = zelf.class().__module__(vm);

let qualified_name = if zelf.class().is(Self::class(&vm.ctx)) {
// For the base partial class, always use functools.partial
"functools.partial".to_owned()
} else {
// For subclasses, check if they're defined in __main__ or test modules
match module.downcast::<crate::builtins::PyStr>() {
Ok(module_str) => {
let module_name = module_str.as_str();
match module_name {
"builtins" | "" | "__main__" => class_name.to_owned(),
name if name.starts_with("test.") || name == "test" => {
// For test modules, just use the class name without module prefix
class_name.to_owned()
}
_ => format!("{module_name}.{class_name}"),
}
let qualified_name = match module.downcast::<crate::builtins::PyStr>() {
Ok(module_str) => {
let module_name = module_str.as_str();
match module_name {
"builtins" | "" => qualname_str,
_ => format!("{module_name}.{qualname_str}"),
}
Err(_) => class_name.to_owned(),
}
Err(_) => qualname_str,
};

Ok(format!(
Expand Down