Skip to content

impl os functions #6484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Dec 25, 2025
Merged

impl os functions #6484

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
18f0f2b
os.setpgrp
youknowone Dec 24, 2025
b74f657
tcgetpgrp
youknowone Dec 24, 2025
75774d1
impl more os functions
youknowone Dec 24, 2025
fd18784
impl PathConverter
youknowone Dec 24, 2025
fc63eef
fix windows error
youknowone Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix windows error
  • Loading branch information
@youknowone
youknowone committed Dec 24, 2025
commit fc63eef96cf09aefefc220e55a6b33642b72e146
19 changes: 15 additions & 4 deletions crates/vm/src/stdlib/nt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ pub(crate) mod module {
builtins::{PyBaseExceptionRef, PyDictRef, PyListRef, PyStrRef, PyTupleRef},
common::{crt_fd, suppress_iph, windows::ToWideString},
convert::ToPyException,
exceptions::OSErrorBuilder,
function::{Either, OptionalArg},
ospath::{OsPath, OsPathOrFd},
stdlib::os::{_os, DirFd, SupportFunc, TargetIsDirectory},
Expand Down Expand Up @@ -193,10 +194,12 @@ pub(crate) mod module {
};

// Use symlink_metadata to avoid following dangling symlinks
let meta = fs::symlink_metadata(&actual_path).map_err(|err| err.to_pyexception(vm))?;
let meta = fs::symlink_metadata(&actual_path)
.map_err(|err| OSErrorBuilder::with_filename(&err, path.clone(), vm))?;
let mut permissions = meta.permissions();
permissions.set_readonly(mode & S_IWRITE == 0);
fs::set_permissions(&*actual_path, permissions).map_err(|err| err.to_pyexception(vm))
fs::set_permissions(&*actual_path, permissions)
.map_err(|err| OSErrorBuilder::with_filename(&err, path, vm))
}

/// Get the real file name (with correct case) without accessing the file.
Expand Down Expand Up @@ -1602,7 +1605,11 @@ pub(crate) mod module {
};

if handle == INVALID_HANDLE_VALUE {
return Err(io::Error::last_os_error().to_pyexception(vm));
return Err(OSErrorBuilder::with_filename(
&io::Error::last_os_error(),
path.clone(),
vm,
));
}

// Buffer for reparse data - MAXIMUM_REPARSE_DATA_BUFFER_SIZE is 16384
Expand All @@ -1626,7 +1633,11 @@ pub(crate) mod module {
unsafe { CloseHandle(handle) };

if result == 0 {
return Err(io::Error::last_os_error().to_pyexception(vm));
return Err(OSErrorBuilder::with_filename(
&io::Error::last_os_error(),
path.clone(),
vm,
));
}

// Parse the reparse data buffer
Expand Down
Loading