Skip to content

flag: DISALLOW_INSTANTIATION #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Dec 16, 2025
Merged

flag: DISALLOW_INSTANTIATION #6445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
238b595
Set tp_new slot when build heap/static type
Snowapril Jun 16, 2024
555363e
Improve type tp_call impl to check tp_new existence and error if not …
Snowapril Jun 16, 2024
22e84a0
Set DISALLOW_INSTANTIATION flag on several types according to cpython…
Snowapril Jun 16, 2024
73a8dd0
Allow #[pyslot] for function pointer
youknowone Dec 15, 2025
2e71cd7
Fix DISALLOW_INSTANTIATION
youknowone Dec 15, 2025
639e89a
apply review
youknowone Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
apply review
  • Loading branch information
@youknowone
youknowone committed Dec 16, 2025
commit 639e89adc5ee3269880f457e069d425e1cdb55af
5 changes: 0 additions & 5 deletions crates/derive-impl/src/pyclass.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1614,7 +1614,6 @@ fn extract_impl_attrs(attr: PunctuatedNestedMeta, item: &Ident) -> Result<Extrac
}];
let mut payload = None;

let mut has_constructor = false;
for attr in attr {
match attr {
NestedMeta::Meta(Meta::List(MetaList { path, nested, .. })) => {
Expand All @@ -1639,9 +1638,6 @@ fn extract_impl_attrs(attr: PunctuatedNestedMeta, item: &Ident) -> Result<Extrac
"Try `#[pyclass(with(Constructor, ...))]` instead of `#[pyclass(with(DefaultConstructor, ...))]`. DefaultConstructor implicitly implements Constructor."
)
}
if path.is_ident("Constructor") {
has_constructor = true;
}
(
quote!(<Self as #path>::__extend_py_class),
quote!(<Self as #path>::__OWN_METHOD_DEFS),
Expand Down Expand Up @@ -1694,7 +1690,6 @@ fn extract_impl_attrs(attr: PunctuatedNestedMeta, item: &Ident) -> Result<Extrac
attr => bail_span!(attr, "Unknown pyimpl attribute"),
}
}
let _ = has_constructor;

Ok(ExtractedImplAttrs {
payload,
Expand Down
11 changes: 0 additions & 11 deletions crates/vm/src/builtins/type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,17 +443,6 @@ impl PyType {
}

fn set_new(slots: &PyTypeSlots, base: &Option<PyTypeRef>) {
// if self.slots.new.load().is_none()
// && self
// .base
// .as_ref()
// .map(|base| base.class().is(ctx.types.object_type))
// .unwrap_or(false)
// && self.slots.flags.contains(PyTypeFlags::HEAPTYPE)
// {
// self.slots.flags |= PyTypeFlags::DISALLOW_INSTANTIATION;
// }

if slots.flags.contains(PyTypeFlags::DISALLOW_INSTANTIATION) {
slots.new.store(None)
} else if slots.new.load().is_none() {
Expand Down
Loading