Skip to content

a few unreachable->unimplemented, clippy #6405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Dec 11, 2025
Merged

a few unreachable->unimplemented, clippy #6405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebfc3ea
unreachable -> unimplemented
youknowone Dec 11, 2025
6df0374
Fix clippy on 1.92
youknowone Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
unreachable -> unimplemented
  • Loading branch information
@youknowone
youknowone committed Dec 11, 2025
commit ebfc3eabae2aa1d189fbf82d82252f99d108cf23
4 changes: 2 additions & 2 deletions crates/stdlib/src/contextvars.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ mod _contextvars {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down Expand Up @@ -585,7 +585,7 @@ mod _contextvars {
Err(vm.new_runtime_error("Tokens can only be created by ContextVars"))
}
fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/stdlib/src/ssl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4116,7 +4116,7 @@ mod _ssl {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/bool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ impl Constructor for PyBool {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/classmethod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ impl Constructor for PyClassMethod {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/int.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ impl Constructor for PyInt {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ impl Constructor for PyBaseObject {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/staticmethod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ impl Constructor for PyStaticMethod {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1289,7 +1289,7 @@ impl Constructor for PyType {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/weakref.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ impl Constructor for PyWeak {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/exceptions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ impl Constructor for PyBaseException {
}

fn py_new(_cls: &Py<PyType>, _args: FuncArgs, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/stdlib/ast/python.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ pub(crate) mod _ast {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
4 changes: 2 additions & 2 deletions crates/vm/src/stdlib/ctypes/array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ impl Constructor for PyCArrayType {
type Args = PyObjectRef;

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down Expand Up @@ -305,7 +305,7 @@ impl Constructor for PyCArray {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/stdlib/ctypes/base.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ impl Constructor for PyCSimple {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/stdlib/ctypes/function.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ impl Constructor for PyCFuncPtr {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/stdlib/ctypes/pointer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ impl Constructor for PyCPointer {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
4 changes: 2 additions & 2 deletions crates/vm/src/stdlib/ctypes/structure.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ impl Constructor for PyCStructType {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down Expand Up @@ -332,7 +332,7 @@ impl Constructor for PyCStructure {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
4 changes: 2 additions & 2 deletions crates/vm/src/stdlib/ctypes/union.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ impl Constructor for PyCUnionType {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down Expand Up @@ -191,7 +191,7 @@ impl Constructor for PyCUnion {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/vm/src/stdlib/itertools.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1256,7 +1256,7 @@ mod decl {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down
4 changes: 2 additions & 2 deletions crates/vm/src/stdlib/typevar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ impl Constructor for ParamSpec {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down Expand Up @@ -772,7 +772,7 @@ impl Constructor for TypeVarTuple {
}

fn py_new(_cls: &Py<PyType>, _args: Self::Args, _vm: &VirtualMachine) -> PyResult<Self> {
unreachable!("use slot_new")
unimplemented!("use slot_new")
}
}

Expand Down