Skip to content

Use rust idioms for accessing a Vec in codegen/src/compile.rs #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Dec 4, 2025
Merged

Use rust idioms for accessing a Vec in codegen/src/compile.rs #6326

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee7377e
Use rust idioms for accessing a `Vec`
ShaharNaveh Dec 3, 2025
e24221b
clippy
ShaharNaveh Dec 3, 2025
83c1ff1
Remove `unsafe`
ShaharNaveh Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unsafe
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Dec 3, 2025
commit 83c1ff1b783a08c4093d488241d8e466b04318cf
3 changes: 1 addition & 2 deletions crates/codegen/src/compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,8 +625,7 @@ impl Compiler {

// Push the next table onto the stack
self.symbol_table_stack.push(table);
// SAFETY: We just pushed, so it can't be empty
unsafe { self.symbol_table_stack.last().unwrap_unchecked() }
self.current_symbol_table()
}

/// Pop the current symbol table off the stack
Expand Down
Loading