Skip to content

Opcode metadata auto generation #6174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ShaharNaveh wants to merge 44 commits into
base: main
Choose a base branch
from
Draft

Opcode metadata auto generation #6174

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
21d9632
POC: automated instruction gen
ShaharNaveh Sep 23, 2025
f6ab8d2
Add generated file
ShaharNaveh Sep 23, 2025
b8ebe9b
Add note about pseudos opcode
ShaharNaveh Sep 23, 2025
8510815
Use `properties.oparg` instead
ShaharNaveh Sep 23, 2025
bcea0bf
Sort by id. impl TryFrom
ShaharNaveh Sep 25, 2025
c7ffa2a
Have `is_valid` as a seperate method
ShaharNaveh Sep 25, 2025
f1948c6
Include in tree
ShaharNaveh Sep 25, 2025
84c7f45
Impl `has_X` methods
ShaharNaveh Sep 25, 2025
9adf908
is_pseudo
ShaharNaveh Sep 25, 2025
99ed360
Set `Self::`
ShaharNaveh Sep 25, 2025
56c0dc8
refactor
ShaharNaveh Sep 26, 2025
3fdc479
impl num_{pushed,popped}
ShaharNaveh Sep 26, 2025
5cf1888
Resolve some errors
ShaharNaveh Sep 26, 2025
eaee21e
Sort like cpython does it
ShaharNaveh Sep 26, 2025
acd74c7
Make more things compile
ShaharNaveh Sep 26, 2025
f71ad1b
Don't use the new Instruction yet
ShaharNaveh Oct 5, 2025
b860f65
pivot to only generating opcodeid atm
ShaharNaveh Oct 5, 2025
ff4fb09
Remove `enum` related code
ShaharNaveh Oct 5, 2025
493da32
Use `OpcodeId` in `_opcode`
ShaharNaveh Oct 5, 2025
657660f
add auto generated file to .gitattributes
ShaharNaveh Oct 5, 2025
eacab03
clippy
ShaharNaveh Oct 5, 2025
7b36086
Apply coderabbit suggestion
ShaharNaveh Oct 5, 2025
dd761d0
Switch back to enum
ShaharNaveh Oct 5, 2025
aeedbdc
Re-add `num_{popped,pushed}`
ShaharNaveh Oct 5, 2025
33a90f3
Improve `_opcode.stack_effect`
ShaharNaveh Oct 5, 2025
4a11f38
Add missing dis attrs for tests
ShaharNaveh Oct 5, 2025
029e534
Unmark passing tests
ShaharNaveh Oct 5, 2025
11369f8
More changes to `dis.py` from 3.13.7
ShaharNaveh Oct 5, 2025
a5813ea
Add reason for failing tests
ShaharNaveh Oct 5, 2025
6e6accd
Base `Opcode` impl
ShaharNaveh Oct 6, 2025
f8a887a
clippy
ShaharNaveh Oct 6, 2025
a2014b5
Fix another test
ShaharNaveh Oct 6, 2025
6c48b49
clippy
ShaharNaveh Oct 6, 2025
46f3e29
clippy
ShaharNaveh Oct 6, 2025
742b709
cspell
ShaharNaveh Oct 6, 2025
2a8fb1e
Add `new_unchecked`
ShaharNaveh Oct 6, 2025
465528e
More docs
ShaharNaveh Oct 6, 2025
e437232
unused import
ShaharNaveh Oct 6, 2025
1ae0c7e
nits
ShaharNaveh Oct 6, 2025
28bab70
Trigger CI
ShaharNaveh Oct 6, 2025
fe3f94a
Merge remote-tracking branch 'upstream/main' into instruction-autogen
ShaharNaveh Oct 13, 2025
aca4508
Use `num_enum` for opcode enums
ShaharNaveh Oct 13, 2025
3daec5a
Remove unused code
ShaharNaveh Oct 13, 2025
9436354
typo
ShaharNaveh Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-add num_{popped,pushed}
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Oct 5, 2025
commit aeedbdc661c49c08b9e17ca2a45e4a3538883e7b
Loading