Skip to content

Type alias type #6011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Jul 21, 2025
Merged

Type alias type #6011

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e326a01
Constructor for TypeAliasType
youknowone Jul 20, 2025
50a6a83
Fix PyBaseObject::py_new
youknowone Jul 20, 2025
2c7692b
Representable for TypeAliasType
youknowone Jul 20, 2025
607212e
Fix tests
youknowone Jul 20, 2025
09c340a
Fix AST
youknowone Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix AST
  • Loading branch information
@youknowone
youknowone committed Jul 21, 2025
commit 09c340af09fb5b648eda421b994ecea88776c1cd
2 changes: 2 additions & 0 deletions Lib/test/test_ast/test_ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,8 @@ class S(str):
with assertNumDeprecated():
self.assertNotIsInstance(Constant(S("42")), Num)

# TODO: RUSTPYTHON; will be removed in Python 3.14
@unittest.expectedFailure
def test_constant_subclasses_deprecated(self):
with warnings.catch_warnings():
warnings.filterwarnings("ignore", "", DeprecationWarning)
Expand Down
33 changes: 31 additions & 2 deletions vm/src/stdlib/ast/python.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,16 @@ use super::{PY_CF_OPTIMIZED_AST, PY_CF_TYPE_COMMENTS, PY_COMPILE_FLAG_AST_ONLY};
pub(crate) mod _ast {
use crate::{
AsObject, Context, PyObjectRef, PyPayload, PyResult, VirtualMachine,
builtins::{PyStrRef, PyTupleRef},
builtins::{PyStrRef, PyTupleRef, PyTypeRef},
function::FuncArgs,
types::Constructor,
};
#[pyattr]
#[pyclass(module = "_ast", name = "AST")]
#[derive(Debug, PyPayload)]
pub(crate) struct NodeAst;

#[pyclass(flags(BASETYPE, HAS_DICT))]
#[pyclass(with(Constructor), flags(BASETYPE, HAS_DICT))]
impl NodeAst {
#[pyslot]
#[pymethod]
Expand Down Expand Up @@ -52,6 +53,34 @@ pub(crate) mod _ast {
}
}

impl Constructor for NodeAst {
type Args = FuncArgs;

fn slot_new(cls: PyTypeRef, args: FuncArgs, vm: &VirtualMachine) -> PyResult {
// AST nodes accept extra arguments (unlike object.__new__)
// This matches CPython's behavior where AST has its own tp_new
let dict = if cls
.slots
.flags
.contains(crate::types::PyTypeFlags::HAS_DICT)
{
Some(vm.ctx.new_dict())
} else {
None
};
let zelf = vm.ctx.new_base_object(cls, dict);

// Initialize the instance with the provided arguments
NodeAst::__init__(zelf.clone(), args, vm)?;

Ok(zelf)
}

fn py_new(_cls: PyTypeRef, _args: Self::Args, _vm: &VirtualMachine) -> PyResult {
unreachable!("slow_new is implemented");
}
}

#[pyattr(name = "PyCF_ONLY_AST")]
use super::PY_COMPILE_FLAG_AST_ONLY;

Expand Down
Loading