Skip to content

Update logging from 3.13.5 #6003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Jul 20, 2025
Merged

Update logging from 3.13.5 #6003

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61439e9
Update logging from 3.13.5
ShaharNaveh Jul 19, 2025
b4b8dd3
Mark failing tests
ShaharNaveh Jul 19, 2025
9d7765e
Mark some failing windows tests
ShaharNaveh Jul 19, 2025
4da9b27
Skip flaky test
ShaharNaveh Jul 19, 2025
673618e
Mark more failing tests
ShaharNaveh Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark failing tests
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jul 19, 2025
commit b4b8dd3f664a5e548510c85914e88dd838a0d1ac
18 changes: 18 additions & 0 deletions Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,6 +1115,8 @@ class SMTPHandlerTest(BaseTest):
# bpo-14314, bpo-19665, bpo-34092: don't wait forever
TIMEOUT = support.LONG_TIMEOUT

# TODO: RUSTPYTHON
@unittest.skip(reason="RUSTPYTHON hangs")
def test_basic(self):
sockmap = {}
server = TestSMTPServer((socket_helper.HOST, 0), self.process_message, 0.001,
Expand Down Expand Up @@ -4056,6 +4058,8 @@ def _mpinit_issue121723(qspec, message_to_log):
# log a message (this creates a record put in the queue)
logging.getLogger().info(message_to_log)

# TODO: RUSTPYTHON; ImportError: cannot import name 'SemLock'
@unittest.expectedFailure
@skip_if_tsan_fork
@support.requires_subprocess()
def test_multiprocessing_queues(self):
Expand Down Expand Up @@ -4115,6 +4119,8 @@ def test_90195(self):
# Logger should be enabled, since explicitly mentioned
self.assertFalse(logger.disabled)

# TODO: RUSTPYTHON; ImportError: cannot import name 'SemLock'
@unittest.expectedFailure
def test_111615(self):
# See gh-111615
import_helper.import_module('_multiprocessing') # see gh-113692
Expand Down Expand Up @@ -4163,6 +4169,8 @@ def __init__(self, *args, **kwargs):
handler = logging.getHandlerByName('custom')
self.assertEqual(handler.custom_kwargs, custom_kwargs)

# TODO: RUSTPYTHON; ImportError: cannot import name 'SemLock'
@unittest.expectedFailure
# See gh-91555 and gh-90321
@support.requires_subprocess()
def test_deadlock_in_queue(self):
Expand Down Expand Up @@ -4653,6 +4661,8 @@ def test_dollars(self):
f = logging.Formatter('${asctime}--', style='$')
self.assertTrue(f.usesTime())

# TODO: RUSTPYTHON; ValueError: Unexpected error parsing format string
@unittest.expectedFailure
def test_format_validate(self):
# Check correct formatting
# Percentage style
Expand Down Expand Up @@ -4826,6 +4836,8 @@ def test_defaults_parameter(self):
def test_invalid_style(self):
self.assertRaises(ValueError, logging.Formatter, None, None, 'x')

# TODO: RUSTPYTHON; AttributeError: 'struct_time' object has no attribute 'tm_gmtoff'
@unittest.expectedFailure
def test_time(self):
r = self.get_record()
dt = datetime.datetime(1993, 4, 21, 8, 3, 0, 0, utc)
Expand All @@ -4840,6 +4852,8 @@ def test_time(self):
f.format(r)
self.assertEqual(r.asctime, '1993-04-21 08:03:00,123')

# TODO: RUSTPYTHON; AttributeError: 'struct_time' object has no attribute 'tm_gmtoff'
@unittest.expectedFailure
def test_default_msec_format_none(self):
class NoMsecFormatter(logging.Formatter):
default_msec_format = None
Expand Down Expand Up @@ -5241,6 +5255,8 @@ def __init__(self, name='MyLogger', level=logging.NOTSET):
h.close()
logging.setLoggerClass(logging.Logger)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_logging_at_shutdown(self):
# bpo-20037: Doing text I/O late at interpreter shutdown must not crash
code = textwrap.dedent("""
Expand All @@ -5260,6 +5276,8 @@ def __del__(self):
self.assertIn("exception in __del__", err)
self.assertIn("ValueError: some error", err)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_logging_at_shutdown_open(self):
# bpo-26789: FileHandler keeps a reference to the builtin open()
# function to be able to open or reopen the file during Python
Expand Down