Skip to content

Pin rustc nightly to nightly-2025-07-18 for miri tests #5999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Jul 19, 2025
Merged

Pin rustc nightly to nightly-2025-07-18 for miri tests #5999

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa7849d
Pin rustc nightly to `nightly-2025-07-18` for miri tests
ShaharNaveh Jul 19, 2025
6b1e4a7
Fix indent
ShaharNaveh Jul 19, 2025
95880ce
Set the miri rustc channel via env var
ShaharNaveh Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Set the miri rustc channel via env var
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jul 19, 2025
commit 95880cee722ccb46f0016432e64e3853d13d8a55
7 changes: 4 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,19 +348,20 @@ jobs:
name: Run tests under miri
runs-on: ubuntu-latest
timeout-minutes: 30
env:
RUSTUP_TOOLCHAIN: nightly-2025-07-18 # TODO: Set to "nightly" once https://github.com/rust-lang/rust/issues/144168 is fixed
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly-2025-07-18 # TODO: Set to "nightly" once https://github.com/rust-lang/rust/issues/144168 is fixed
toolchain: ${{ env.RUSTUP_TOOLCHAIN }}
components: miri

- uses: Swatinem/rust-cache@v2
- name: Run tests under miri
# miri-ignore-leaks because the type-object circular reference means that there will always be
# a memory leak, at least until we have proper cyclic gc
# run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +nightly miri test -p rustpython-vm -- miri_test
run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +nightly-2025-07-18 miri test -p rustpython-vm -- miri_test
run: MIRIFLAGS='-Zmiri-ignore-leaks' cargo +${{ env.RUSTUP_TOOLCHAIN }} miri test -p rustpython-vm -- miri_test

wasm:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip:ci') }}
Expand Down
Loading