Skip to content

Wtf8-compatible fixes #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 7 commits into from
Jul 29, 2025
Merged

Wtf8-compatible fixes #5985

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ed36ac8
deprecate more payload_* functions
youknowone Jul 16, 2025
9019b6f
loose trait bount for PyInterned
youknowone Jul 15, 2025
95bf98e
Fix levenstein
youknowone Jul 28, 2025
a581614
Fix genericalias
youknowone Jul 28, 2025
9c649eb
Fix PyBoundMethod::repr
youknowone Jul 28, 2025
fc2b97d
fix repr
youknowone Jul 28, 2025
34b9562
Fix fromhex
youknowone Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix levenstein
  • Loading branch information
@youknowone
youknowone committed Jul 29, 2025
commit 95bf98e159174befd2c36623ec19d03c85d91a2f
4 changes: 2 additions & 2 deletions common/src/str.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ pub mod levenshtein {
if a == b { CASE_COST } else { MOVE_COST }
}

pub fn levenshtein_distance(a: &str, b: &str, max_cost: usize) -> usize {
pub fn levenshtein_distance(a: &[u8], b: &[u8], max_cost: usize) -> usize {
thread_local! {
#[allow(clippy::declare_interior_mutable_const)]
static BUFFER: RefCell<[usize; MAX_STRING_SIZE]> = const {
Expand All @@ -499,7 +499,7 @@ pub mod levenshtein {
return 0;
}

let (mut a_bytes, mut b_bytes) = (a.as_bytes(), b.as_bytes());
let (mut a_bytes, mut b_bytes) = (a, b);
let (mut a_begin, mut a_end) = (0usize, a.len());
let (mut b_begin, mut b_end) = (0usize, b.len());

Expand Down
4 changes: 2 additions & 2 deletions vm/src/suggestion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ pub fn calculate_suggestions<'a>(

for item in dir_iter {
let item_name = item.downcast_ref::<PyStr>()?;
if name.as_str() == item_name.as_str() {
if name.as_bytes() == item_name.as_bytes() {
continue;
}
// No more than 1/3 of the characters should need changed
Expand All @@ -35,7 +35,7 @@ pub fn calculate_suggestions<'a>(
suggestion_distance - 1,
);
let current_distance =
levenshtein_distance(name.as_str(), item_name.as_str(), max_distance);
levenshtein_distance(name.as_bytes(), item_name.as_bytes(), max_distance);
if current_distance > max_distance {
continue;
}
Expand Down