Skip to content

Update str related tests from 3.13.5 #5953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Jul 12, 2025
Merged

Update str related tests from 3.13.5 #5953

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46c7bf7
Update str related tests from 3.13.5
ShaharNaveh Jul 12, 2025
58602a3
Apply RustPython patches
ShaharNaveh Jul 12, 2025
2d8a3cb
Mark new failing tests
ShaharNaveh Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Mark new failing tests
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jul 12, 2025
commit 2d8a3cb76c4a0f74c439b756110a837a8ff6c969
2 changes: 2 additions & 0 deletions Lib/test/string_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ def test_count(self):
self.assertEqual(rem, 0, '%s != 0 for %s' % (rem, i))
self.assertEqual(r1, r2, '%s != %s for %s' % (r1, r2, i))

# TODO: RUSTPYTHON; TypeError: Unexpected keyword argument count
@unittest.expectedFailure
def test_count_keyword(self):
self.assertEqual('aa'.replace('a', 'b', 0), 'aa'.replace('a', 'b', count=0))
self.assertEqual('aa'.replace('a', 'b', 1), 'aa'.replace('a', 'b', count=1))
Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_str.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ def test_literals(self):
# raw strings should not have unicode escapes
self.assertNotEqual(r"\u0020", " ")

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_ascii(self):
self.assertEqual(ascii('abc'), "'abc'")
self.assertEqual(ascii('ab\\c'), "'ab\\\\c'")
Expand Down Expand Up @@ -2699,6 +2701,8 @@ def test_check_encoding_errors(self):
proc = assert_python_failure('-X', 'dev', '-c', code)
self.assertEqual(proc.rc, 10, proc)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_str_invalid_call(self):
# too many args
with self.assertRaisesRegex(TypeError, r"str expected at most 3 arguments, got 4"):
Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_unicodedata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ def test_no_names_in_pua(self):
char = chr(i)
self.assertRaises(ValueError, self.db.name, char)

# TODO: RUSTPYTHON; LookupError: undefined character name 'LATIN SMLL LETR A'
@unittest.expectedFailure
def test_lookup_nonexistant(self):
# just make sure that lookup can fail
for nonexistant in [
Expand Down Expand Up @@ -273,6 +275,8 @@ def test_east_asian_width(self):
self.assertEqual(eaw('\u2010'), 'A')
self.assertEqual(eaw('\U00020000'), 'W')

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_east_asian_width_unassigned(self):
eaw = self.db.east_asian_width
# unassigned
Expand Down
Loading