Skip to content

typing __parameters__ __type_params__ #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Jul 7, 2025
Merged

typing __parameters__ __type_params__ #5909

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
999976a
fix __parametesr__
youknowone Jul 3, 2025
481e03a
Replace old anndata to new from CPython 3.13.5
youknowone Jul 7, 2025
bd54e53
Fix __parameters__, __type_params__
youknowone Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix __parametesr__
  • Loading branch information
@youknowone
youknowone committed Jul 7, 2025
commit 999976a76c7e845f717fec516ac06d5bc638d06f
2 changes: 0 additions & 2 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6106,8 +6106,6 @@ class C(Generic[T]): pass
self.assertIs(get_origin((*tuple[*Ts],)[0]), tuple)
self.assertIs(get_origin(Unpack[Tuple[Unpack[Ts]]]), Unpack)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_get_args(self):
T = TypeVar('T')
class C(Generic[T]): pass
Expand Down
4 changes: 3 additions & 1 deletion vm/src/stdlib/builtins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,9 @@ mod builtins {
{
if let Some(type_params_tuple) = type_params.downcast_ref::<PyTuple>() {
if !type_params_tuple.is_empty() {
class.set_attr(identifier!(vm, __type_params__), type_params, vm)?;
class.set_attr(identifier!(vm, __type_params__), type_params.clone(), vm)?;
// Also set __parameters__ for compatibility with typing module
class.set_attr(identifier!(vm, __parameters__), type_params, vm)?;
}
}
}
Expand Down