Skip to content

[5895] added code to raise error in sleep if invalid value #5907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DominicPrince2003 wants to merge 3 commits into
base: main
Choose a base branch
from
+40 −5
Open

[5895] added code to raise error in sleep if invalid value #5907

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
435159e
[5895] added code to raise error in sleep if invalid value
DominicPrince2003 Jul 6, 2025
cdff22f
Update vm/src/stdlib/time.rs
DominicPrince2003 Jul 6, 2025
a9f152c
changed max sleep for not unix systems
DominicPrince2003 Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
changed max sleep for not unix systems
  • Loading branch information
@DominicPrince2003
DominicPrince2003 authored Jul 6, 2025
commit a9f152c2160dc0819e5e3861d3acf2777c284eb6
2 changes: 1 addition & 1 deletion vm/src/stdlib/time.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ mod decl {
} else {
return Err(vm.new_type_error("sleep() argument must be a number"));
};
if !secs.is_finite() || secs < 0.0 || secs > u64::MAX as f64 {
if !secs.is_finite() || secs < 0.0 || secs > (u32::MAX / 1000) as f64 {
return Err(vm.new_value_error("sleep length must be a non-negative finite number"));
}
Comment on lines +94 to +104
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This validation logic is duplicated in the unix implementation of sleep as well (lines 710-720). To improve maintainability and avoid code duplication, consider extracting this logic into a shared helper function. This function could be defined at the module level and be called by both sleep implementations.

For example:

fn get_sleep_secs(secs_obj: PyObjectRef, vm: &VirtualMachine) -> PyResult<f64> {
    // Try to get as float first, if that fails try as integer
    let secs = if let Ok(float_val) = f64::try_from_object(vm, secs_obj.clone()) {
        float_val
    } else if let Ok(int_val) = i64::try_from_object(vm, secs_obj) {
        int_val as f64
    } else {
        return Err(vm.new_type_error("sleep() argument must be a number"));
    };

    if !secs.is_finite() || secs < 0.0 || secs > u64::MAX as f64 {
        return Err(vm.new_value_error("sleep length must be a non-negative finite number"));
    }
    Ok(secs)
}


Expand Down