Skip to content

Use const fn where possible #5894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 17 commits into from
Jul 4, 2025
Merged

Use const fn where possible #5894

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b30c919
vm
ShaharNaveh Jul 3, 2025
a18f0c2
compiler
ShaharNaveh Jul 3, 2025
fde322c
sre engine
ShaharNaveh Jul 3, 2025
80fba2f
compiler
ShaharNaveh Jul 3, 2025
5f790b8
common
ShaharNaveh Jul 3, 2025
8aef1a3
stdlib
ShaharNaveh Jul 3, 2025
5e08620
vm
ShaharNaveh Jul 3, 2025
4e91f6a
cargo fmt
ShaharNaveh Jul 3, 2025
593b9d2
Merge remote-tracking branch 'upstream/main' into constify
ShaharNaveh Jul 4, 2025
29b26d3
vm
ShaharNaveh Jul 4, 2025
6cd01bf
vm
ShaharNaveh Jul 4, 2025
6b1deb4
common
ShaharNaveh Jul 4, 2025
8adcaa5
compiler
ShaharNaveh Jul 4, 2025
dbf0078
compiler codegen
ShaharNaveh Jul 4, 2025
4b12536
vm
ShaharNaveh Jul 4, 2025
e55f32b
cargo fmt
ShaharNaveh Jul 4, 2025
eb3e2b3
remove bad consts
ShaharNaveh Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
compiler codegen
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jul 4, 2025
commit dbf0078c778c53db3333779cc22ae4e7aef6952a
4 changes: 2 additions & 2 deletions compiler/codegen/src/compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ impl Default for PatternContext {
}

impl PatternContext {
pub fn new() -> Self {
pub const fn new() -> Self {
Self {
stores: Vec::new(),
allow_irrefutable: false,
Expand Down Expand Up @@ -4118,7 +4118,7 @@ impl Compiler<'_> {
code.current_block = block;
}

fn set_source_range(&mut self, range: TextRange) {
const fn set_source_range(&mut self, range: TextRange) {
self.current_source_range = range;
}

Expand Down
2 changes: 1 addition & 1 deletion compiler/codegen/src/string_parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ struct StringParser {
}

impl StringParser {
fn new(source: Box<str>, flags: AnyStringFlags) -> Self {
const fn new(source: Box<str>, flags: AnyStringFlags) -> Self {
Self {
source,
cursor: 0,
Expand Down
6 changes: 3 additions & 3 deletions compiler/codegen/src/symboltable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,18 +162,18 @@ impl Symbol {
}
}

pub fn is_global(&self) -> bool {
pub const fn is_global(&self) -> bool {
matches!(
self.scope,
SymbolScope::GlobalExplicit | SymbolScope::GlobalImplicit
)
}

pub fn is_local(&self) -> bool {
pub const fn is_local(&self) -> bool {
matches!(self.scope, SymbolScope::Local | SymbolScope::Cell)
}

pub fn is_bound(&self) -> bool {
pub const fn is_bound(&self) -> bool {
self.flags.intersects(SymbolFlags::BOUND)
}
}
Expand Down
4 changes: 2 additions & 2 deletions compiler/codegen/src/unparse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ struct Unparser<'a, 'b, 'c> {
source: &'c SourceCode<'c>,
}
impl<'a, 'b, 'c> Unparser<'a, 'b, 'c> {
fn new(f: &'b mut fmt::Formatter<'a>, source: &'c SourceCode<'c>) -> Self {
const fn new(f: &'b mut fmt::Formatter<'a>, source: &'c SourceCode<'c>) -> Self {
Unparser { f, source }
}

Expand Down Expand Up @@ -602,7 +602,7 @@ pub struct UnparseExpr<'a> {
source: &'a SourceCode<'a>,
}

pub fn unparse_expr<'a>(expr: &'a Expr, source: &'a SourceCode<'a>) -> UnparseExpr<'a> {
pub const fn unparse_expr<'a>(expr: &'a Expr, source: &'a SourceCode<'a>) -> UnparseExpr<'a> {
UnparseExpr { expr, source }
}

Expand Down