Skip to content

Upgrade typing to 3.13.5 #5850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Jun 30, 2025
Merged

Upgrade typing to 3.13.5 #5850

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5946d4
Update typing.py from CPython 3.13.5
youknowone Jun 27, 2025
39d091f
Fix typing
youknowone Jun 28, 2025
5a2007f
renames
youknowone Jun 30, 2025
c0b9694
Patch `typing.py` to let `_py_abc` fallback
youknowone Jun 30, 2025
3f5566d
Fix _typing.override
youknowone Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix _typing.override
  • Loading branch information
@youknowone
youknowone committed Jun 30, 2025
commit 3f5566da53a35592a1006c0c01075edc956787bd
6 changes: 0 additions & 6 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3351,8 +3351,6 @@ def x(self): ...
self.assertNotIsSubclass(C, Protocol)
self.assertNotIsInstance(C(), Protocol)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_protocols_issubclass_non_callable(self):
class C:
x = 1
Expand Down Expand Up @@ -3412,8 +3410,6 @@ def __init__(self) -> None:
):
issubclass(Eggs, Spam)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_no_weird_caching_with_issubclass_after_isinstance_2(self):
@runtime_checkable
class Spam(Protocol):
Expand All @@ -3434,8 +3430,6 @@ class Eggs: ...
):
issubclass(Eggs, Spam)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_no_weird_caching_with_issubclass_after_isinstance_3(self):
@runtime_checkable
class Spam(Protocol):
Expand Down
5 changes: 4 additions & 1 deletion vm/src/stdlib/typing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ pub(crate) mod decl {
#[pyfunction(name = "override")]
pub(crate) fn r#override(func: PyObjectRef, vm: &VirtualMachine) -> PyResult {
// Set __override__ attribute to True
func.set_attr("__override__", vm.ctx.true_value.clone(), vm)?;
// Skip the attribute silently if it is not writable.
// AttributeError happens if the object has __slots__ or a
// read-only property, TypeError if it's a builtin class.
let _ = func.set_attr("__override__", vm.ctx.true_value.clone(), vm);
Ok(func)
}

Expand Down
Loading