Skip to content

Remove unnecessary string conversions in error message construction #5826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 10 commits into from
Jun 24, 2025
Merged

Remove unnecessary string conversions in error message construction #5826

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e7923f6
Make `new_X_error` recv `impl Into<String>`
ShaharNaveh Jun 22, 2025
485dea2
Maks the rest of the methods to be generic
ShaharNaveh Jun 22, 2025
93de8d8
remove to_owned
ShaharNaveh Jun 22, 2025
8d7deb2
Remove `.to_owned()` from more files
ShaharNaveh Jun 23, 2025
9e83d43
Make `new_struct_error` to be generic as well
ShaharNaveh Jun 23, 2025
704cc8f
Remove `.to_owned()` from more places
ShaharNaveh Jun 23, 2025
2eefb81
Resolve wasm errors
ShaharNaveh Jun 23, 2025
628ee03
Merge remote-tracking branch 'upstream/main' into cln-msg-generic-string
ShaharNaveh Jun 24, 2025
ebc88bc
Revert changes to `new_exception_msg` and `new_exception_msg_dict`
ShaharNaveh Jun 24, 2025
324b8be
fix wasm
ShaharNaveh Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix wasm
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jun 24, 2025
commit 324b8be834e8bf544b6c87d7cd67876250929dd0
2 changes: 1 addition & 1 deletion wasm/lib/src/convert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ pub fn js_err_to_py_err(vm: &VirtualMachine, js_err: &JsValue) -> PyBaseExceptio
_ => vm.ctx.exceptions.exception_type,
}
.to_owned();
vm.new_exception_msg(exc_type, err.message())
vm.new_exception_msg(exc_type, err.message().into())
}
None => vm.new_exception_msg(
vm.ctx.exceptions.exception_type.to_owned(),
Expand Down
Loading