Skip to content

functools.partial #5825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Jun 23, 2025
Merged

functools.partial #5825

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be05bc1
functools.partial
youknowone Jun 23, 2025
caefb8e
apply review
youknowone Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
apply review
  • Loading branch information
@youknowone
youknowone committed Jun 23, 2025
commit caefb8e40ffb7788141812a0c698de604619b573
15 changes: 6 additions & 9 deletions vm/src/stdlib/functools.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ mod _functools {
let mut final_kwargs = IndexMap::new();

// Add keywords from self.keywords
for (key, value) in inner.keywords.clone() {
for (key, value) in &*inner.keywords {
let key_str = key
.downcast::<crate::builtins::PyStr>()
.map_err(|_| vm.new_type_error("keywords must be strings".to_owned()))?;
Expand Down Expand Up @@ -291,27 +291,24 @@ mod _functools {
let class_name = zelf.class().name();
let module = zelf.class().module(vm);

// Check if this is a subclass by comparing with the base partial type
let is_subclass = !zelf.class().is(PyPartial::class(&vm.ctx));

let qualified_name = if !is_subclass {
let qualified_name = if zelf.class().is(PyPartial::class(&vm.ctx)) {
// For the base partial class, always use functools.partial
"functools.partial".to_string()
"functools.partial".to_owned()
} else {
// For subclasses, check if they're defined in __main__ or test modules
match module.downcast::<crate::builtins::PyStr>() {
Ok(module_str) => {
let module_name = module_str.as_str();
match module_name {
"builtins" | "" | "__main__" => class_name.to_string(),
"builtins" | "" | "__main__" => class_name.to_owned(),
name if name.starts_with("test.") || name == "test" => {
// For test modules, just use the class name without module prefix
class_name.to_string()
class_name.to_owned()
}
_ => format!("{}.{}", module_name, class_name),
}
}
Err(_) => class_name.to_string(),
Err(_) => class_name.to_owned(),
}
};

Expand Down
Loading