Skip to content

Fix posix tests #5811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 4 commits into from
Jun 22, 2025
Merged

Fix posix tests #5811

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1909aeb
Fix PosixSpawnArgs
youknowone Jun 21, 2025
4078992
test_specify_environment
youknowone Jun 21, 2025
dde4302
fixupo
youknowone Jun 21, 2025
151598c
Apply reviews
youknowone Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply reviews
  • Loading branch information
@youknowone
youknowone committed Jun 22, 2025
commit 151598c19a2b18b73ed27a3e9b397dd2f1ab0ca4
22 changes: 19 additions & 3 deletions vm/src/stdlib/posix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,7 +1486,10 @@ pub mod module {
let mut flags = 0i32;

if let Some(pgid) = self.setpgroup {
assert!(unsafe { libc::posix_spawnattr_setpgroup(&mut attrp, pgid) } == 0);
let ret = unsafe { libc::posix_spawnattr_setpgroup(&mut attrp, pgid) };
if ret != 0 {
return Err(vm.new_os_error(format!("posix_spawnattr_setpgroup failed: {ret}")));
}
flags |= libc::POSIX_SPAWN_SETPGROUP;
}

Expand Down Expand Up @@ -1518,7 +1521,12 @@ pub mod module {
})?;
set.add(sig);
}
assert!(unsafe { libc::posix_spawnattr_setsigmask(&mut attrp, set.as_ref()) } == 0);
let ret = unsafe { libc::posix_spawnattr_setsigmask(&mut attrp, set.as_ref()) };
if ret != 0 {
return Err(
vm.new_os_error(format!("posix_spawnattr_setsigmask failed: {ret}"))
);
}
flags |= libc::POSIX_SPAWN_SETSIGMASK;
}

Expand All @@ -1531,7 +1539,15 @@ pub mod module {
}

if flags != 0 {
assert!(unsafe { libc::posix_spawnattr_setflags(&mut attrp, flags as i16) } == 0);
// Check for potential overflow when casting to c_short
if flags > libc::c_short::MAX as i32 {
return Err(vm.new_value_error("Too many flags set for posix_spawn".to_owned()));
}
let ret =
unsafe { libc::posix_spawnattr_setflags(&mut attrp, flags as libc::c_short) };
if ret != 0 {
return Err(vm.new_os_error(format!("posix_spawnattr_setflags failed: {ret}")));
}
}

let mut args: Vec<CString> = self
Expand Down
Loading