Skip to content

Cleanup match statement codegen #5700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coolreader18 merged 10 commits into from
Apr 18, 2025
Merged

Cleanup match statement codegen #5700

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
49b348c
Remove Instruction::IsOperation
arihant2math Apr 15, 2025
c7042fd
remove unneeded validation
arihant2math Apr 15, 2025
456e555
better error
arihant2math Apr 15, 2025
d47944b
error handling
arihant2math Apr 15, 2025
09c199a
match cleanup
arihant2math Apr 15, 2025
e949c9a
rename
arihant2math Apr 15, 2025
628287c
update snapshot
arihant2math Apr 15, 2025
d44324d
clippy
arihant2math Apr 15, 2025
2127202
improve error handling
arihant2math Apr 15, 2025
4d53f59
remove match test
arihant2math Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unneeded validation
  • Loading branch information
@arihant2math
arihant2math committed Apr 15, 2025
commit c7042fd8470ad8d9ca4c33246d6b390b74855b85
10 changes: 0 additions & 10 deletions compiler/codegen/src/compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2185,16 +2185,6 @@

let nargs = patterns.len();
let n_attrs = kwd_attrs.len();
let nkwd_patterns = kwd_patterns.len();

// Validate that keyword attribute names and patterns match in length.
if n_attrs != nkwd_patterns {
let msg = format!(
"kwd_attrs ({}) / kwd_patterns ({}) length mismatch in class pattern",
n_attrs, nkwd_patterns
);
unreachable!("{}", msg);
}

// Check for too many sub-patterns.
if nargs > u32::MAX as usize || (nargs + n_attrs).saturating_sub(1) > i32::MAX as usize {
Expand Down Expand Up @@ -2483,10 +2473,10 @@

// Adjust the final captures.
let nstores = control.as_ref().unwrap().len();
let nrots = nstores + 1 + pc.on_top + pc.stores.len();

Check warning on line 2476 in compiler/codegen/src/compile.rs

View workflow job for this annotation

GitHub Actions / Check Rust code with rustfmt and clippy 

Unknown word (nrots)
for i in 0..nstores {
// Rotate the capture to its proper place.
self.pattern_helper_rotate(nrots)?;

Check warning on line 2479 in compiler/codegen/src/compile.rs

View workflow job for this annotation

GitHub Actions / Check Rust code with rustfmt and clippy 

Unknown word (nrots)
let name = &control.as_ref().unwrap()[i];
// Check for duplicate binding.
if pc.stores.iter().any(|n| n == name) {
Expand Down
Loading