Skip to content

Remove asynchat and asyncore #5688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Apr 11, 2025
Merged

Remove asynchat and asyncore #5688

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94c6ff5
try to remove asynchat and asyncore
arihant2math Apr 11, 2025
4c35297
remove associated tests
arihant2math Apr 11, 2025
44c0f5f
temp patch of test_ftplib
arihant2math Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
temp patch of test_ftplib
  • Loading branch information
@arihant2math
arihant2math committed Apr 11, 2025
commit 44c0f5ffd328e622840ce5447121d108f44d230a
9 changes: 0 additions & 9 deletions Lib/test/test_ftplib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,6 @@
from test.support import asyncore
from test.support.socket_helper import HOST, HOSTv6

import sys
if sys.platform == 'win32':
raise unittest.SkipTest("test_ftplib not working on windows")
if getattr(sys, '_rustpython_debugbuild', False):
raise unittest.SkipTest("something's weird on debug builds")

asynchat = warnings_helper.import_deprecated('asynchat')
asyncore = warnings_helper.import_deprecated('asyncore')


support.requires_working_socket(module=True)

Expand Down
Loading