Skip to content

Implement faulthandler.dump_traceback_later #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arihant2math wants to merge 1 commit into from
Closed

Implement faulthandler.dump_traceback_later #5564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
implement dump_traceback_later and cancel_dump_traceback_later 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
  • Loading branch information
@arihant2math
arihant2math committed Feb 26, 2025
commit 82b2a898baa87a8a09dbfbc6cb5032b189db310d
95 changes: 94 additions & 1 deletion stdlib/src/faulthandler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,24 @@ pub(crate) use decl::make_module;

#[pymodule(name = "faulthandler")]
mod decl {
use crate::vm::{frame::Frame, function::OptionalArg, stdlib::sys::PyStderr, VirtualMachine};
use crate::vm::{
frame::{Frame, FrameRef},
function::OptionalArg,
stdlib::sys::PyStderr,
VirtualMachine,
};
use rustpython_common::lock::PyRwLock;
use std::io::Write;

struct FaultHandlerThread {
enabled: bool,
repeat: bool,
exit: bool,
timeout: std::time::Duration,
frames: Vec<FrameRef>,
}

static FAULT_HANDLER_THREAD: PyRwLock<Option<FaultHandlerThread>> = PyRwLock::new(None);

fn dump_frame(frame: &Frame, vm: &VirtualMachine) {
let stderr = PyStderr(vm);
Expand All @@ -29,6 +46,82 @@ mod decl {
}
}

#[pyfunction]
fn dump_traceback_later(
timeout: f32,
repeat: OptionalArg<bool>,
_file: OptionalArg<i32>,
exit: OptionalArg<bool>,
vm: &VirtualMachine,
) {
let timeout_duration = std::time::Duration::from_secs_f32(timeout);
let repeat = repeat.unwrap_or(false);
let exit = exit.unwrap_or(false);
let frames = vm.frames.borrow().clone();
let t_data = FaultHandlerThread {
enabled: true,
repeat,
timeout: timeout_duration,
frames,
exit,
};
if let Some(t) = FAULT_HANDLER_THREAD.write().as_mut() {
*t = t_data;
} else {
std::thread::spawn(move || {
loop {
let thread_info = FAULT_HANDLER_THREAD.read();
let thread_info = match thread_info.as_ref() {
Some(t) => t,
None => return,
};
if !thread_info.enabled {
*FAULT_HANDLER_THREAD.write() = None;
return;
}

std::thread::sleep(thread_info.timeout);

let thread_info = FAULT_HANDLER_THREAD.read();
let thread_info = match thread_info.as_ref() {
Some(t) => t,
None => return,
};
if !thread_info.enabled {
*FAULT_HANDLER_THREAD.write() = None;
return;
}
for frame in thread_info.frames.iter() {
// TODO: Fix
let _ = writeln!(std::io::stderr(), "Stack (most recent call first):");
let _ = writeln!(
std::io::stderr(),
" File \"{}\", line {} in {}",
frame.code.source_path,
frame.current_location().row.to_usize(),
frame.code.obj_name
);
}
if thread_info.exit {
std::process::exit(1);
}
if !thread_info.repeat {
*FAULT_HANDLER_THREAD.write() = None;
return;
}
}
});
}
}

#[pyfunction]
fn cancel_dump_traceback_later() {
FAULT_HANDLER_THREAD
.write()
.as_mut()
.map(|t| t.enabled = false);
}

#[derive(FromArgs)]
#[allow(unused)]
struct EnableArgs {
Expand Down