Skip to content

Extend time compat for windows #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Feb 18, 2025
Merged

Extend time compat for windows #5523

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1bfcb23
function to retrieve tz info on windows
arihant2math Feb 18, 2025
42e4292
tzname on windows
arihant2math Feb 18, 2025
edb98eb
time.timezone for windows
arihant2math Feb 18, 2025
77fb165
time.daylight for windows
arihant2math Feb 18, 2025
1380e8d
formatting
arihant2math Feb 18, 2025
2053ab9
clippy
arihant2math Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
clippy 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
  • Loading branch information
@arihant2math
arihant2math committed Feb 18, 2025
commit 2053ab9ca318c08b2298815178fd3cce9bea7f52
4 changes: 2 additions & 2 deletions vm/src/stdlib/time.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ mod decl {
#[cfg(target_env = "msvc")]
#[cfg(not(target_arch = "wasm32"))]
#[pyattr]
fn timezone() -> i32 {
fn timezone(_vm: &VirtualMachine) -> i32 {
let info = get_tz_info();
// https://users.rust-lang.org/t/accessing-tzname-and-similar-constants-in-windows/125771/3
(info.Bias + info.StandardBias) * 60
Expand All @@ -196,7 +196,7 @@ mod decl {
#[cfg(target_env = "msvc")]
#[cfg(not(target_arch = "wasm32"))]
#[pyattr]
fn daylight() -> i32 {
fn daylight(_vm: &VirtualMachine) -> i32 {
let info = get_tz_info();
// https://users.rust-lang.org/t/accessing-tzname-and-similar-constants-in-windows/125771/3
(info.StandardBias != info.DaylightBias) as i32
Expand Down