Fix compile error when using vm-tracing-logging#5436
Merged
youknowone merged 1 commit intoRustPython:mainfrom Nov 26, 2024
Merged
Fix compile error when using vm-tracing-logging#5436youknowone merged 1 commit intoRustPython:mainfrom
vm-tracing-logging#5436youknowone merged 1 commit intoRustPython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to fix #5355, I stumbled upon a compile error when the
vm-tracing-loggingfeature is enabled.This PR fixes the above mentioned compile error.
One other thing that came up, is that /vm/src/protocol/object.rs#L172 generates very long traces and I think that it would be a good idea to use another format since it prints all the data of
selfandvalue.