Skip to content

Async for comprehension #5276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Apr 25, 2024
Merged

Async for comprehension #5276

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2856aff
Begin async list comprehension implementation
aaronclong Mar 6, 2021
61f37b1
implement async for function in compiler
HyeockJinKim Aug 25, 2021
f3501f4
Basic async for comprehension support
youknowone Apr 25, 2024
b58bdc9
Uncomment async for tests
youknowone Apr 25, 2024
f6d8804
Uncomment test_grammar tests
youknowone Apr 25, 2024
408459b
vm runtime debug prints
youknowone Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Uncomment test_grammar tests
  • Loading branch information
@youknowone
youknowone committed Apr 25, 2024
commit f6d88042b55207cd1f6c52af3008af9acffc8d4d
74 changes: 38 additions & 36 deletions Lib/test/test_grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,44 +418,46 @@ def test_var_annot_simple_exec(self):
gns['__annotations__']

# TODO: RUSTPYTHON
# def test_var_annot_custom_maps(self):
# # tests with custom locals() and __annotations__
# ns = {'__annotations__': CNS()}
# exec('X: int; Z: str = "Z"; (w): complex = 1j', ns)
# self.assertEqual(ns['__annotations__']['x'], int)
# self.assertEqual(ns['__annotations__']['z'], str)
# with self.assertRaises(KeyError):
# ns['__annotations__']['w']
# nonloc_ns = {}
# class CNS2:
# def __init__(self):
# self._dct = {}
# def __setitem__(self, item, value):
# nonlocal nonloc_ns
# self._dct[item] = value
# nonloc_ns[item] = value
# def __getitem__(self, item):
# return self._dct[item]
# exec('x: int = 1', {}, CNS2())
# self.assertEqual(nonloc_ns['__annotations__']['x'], int)
@unittest.expectedFailure
def test_var_annot_custom_maps(self):
# tests with custom locals() and __annotations__
ns = {'__annotations__': CNS()}
exec('X: int; Z: str = "Z"; (w): complex = 1j', ns)
self.assertEqual(ns['__annotations__']['x'], int)
self.assertEqual(ns['__annotations__']['z'], str)
with self.assertRaises(KeyError):
ns['__annotations__']['w']
nonloc_ns = {}
class CNS2:
def __init__(self):
self._dct = {}
def __setitem__(self, item, value):
nonlocal nonloc_ns
self._dct[item] = value
nonloc_ns[item] = value
def __getitem__(self, item):
return self._dct[item]
exec('x: int = 1', {}, CNS2())
self.assertEqual(nonloc_ns['__annotations__']['x'], int)

# TODO: RUSTPYTHON
# def test_var_annot_refleak(self):
# # complex case: custom locals plus custom __annotations__
# # this was causing refleak
# cns = CNS()
# nonloc_ns = {'__annotations__': cns}
# class CNS2:
# def __init__(self):
# self._dct = {'__annotations__': cns}
# def __setitem__(self, item, value):
# nonlocal nonloc_ns
# self._dct[item] = value
# nonloc_ns[item] = value
# def __getitem__(self, item):
# return self._dct[item]
# exec('X: str', {}, CNS2())
# self.assertEqual(nonloc_ns['__annotations__']['x'], str)
@unittest.expectedFailure
def test_var_annot_refleak(self):
# complex case: custom locals plus custom __annotations__
# this was causing refleak
cns = CNS()
nonloc_ns = {'__annotations__': cns}
class CNS2:
def __init__(self):
self._dct = {'__annotations__': cns}
def __setitem__(self, item, value):
nonlocal nonloc_ns
self._dct[item] = value
nonloc_ns[item] = value
def __getitem__(self, item):
return self._dct[item]
exec('X: str', {}, CNS2())
self.assertEqual(nonloc_ns['__annotations__']['x'], str)


def test_var_annot_rhs(self):
Expand Down