Skip to content

Add loongarch64 support #4914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Apr 23, 2023
Merged

Add loongarch64 support #4914

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77a9071
Add loongarch64 support
xiangzhai Apr 21, 2023
fe8a72c
It doesn't need to change test_triplet_in_ext_suffix
xiangzhai Apr 23, 2023
cb675f7
Fix cargo fmt check
xiangzhai Apr 23, 2023
f7bb7d7
Fix cargo clippy -Dwarnings unused import warning issue
xiangzhai Apr 23, 2023
ee3e23a
Place allow unused imports under cfg
xiangzhai Apr 23, 2023
c9f1709
Replace allow unused_imports with pyattr
xiangzhai Apr 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix cargo clippy -Dwarnings unused import warning issue
  • Loading branch information
@xiangzhai
xiangzhai committed Apr 23, 2023
commit f7bb7d7c9e4b929c7bbd4f85202f8fd441c1b0df
1 change: 1 addition & 0 deletions stdlib/src/mmap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ mod mmap {
MADV_MERGEABLE, MADV_NOHUGEPAGE, MADV_REMOVE, MADV_UNMERGEABLE,
};

#[allow(unused_imports)]
Copy link
Copy Markdown
Member

@youknowone youknowone Apr 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be used by #[pyattr]

Suggested change
#[allow(unused_imports)]
#[pyattr]

Because we usually use cfg - pyattr order, placing it under cfg will be better.

Copy link
Copy Markdown
Contributor Author

@xiangzhai xiangzhai Apr 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

#[cfg(any(
target_os = "android",
all(
Expand Down