Skip to content

Weakref callback #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BenLewis-Seequent wants to merge 10 commits into from
Closed

Weakref callback #488

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8dd5810
Make PyObjectRef and PyObjectWeakRef it's own type.
skinnyBat Feb 13, 2019
0c1bee9
Move weakref type to obj folder, as it's a core type and needs to be
skinnyBat Feb 16, 2019
eab6e2f
Add callback to object being reference.
skinnyBat Feb 17, 2019
6a13a83
Merge branch 'master' into weakref_callback
skinnyBat Feb 18, 2019
4355105
Queue up objects to be deleted to allow for weakref callbacks
skinnyBat Feb 19, 2019
195a56a
Add more tests for weakref and fix objects not holding there weak
skinnyBat Feb 19, 2019
80c72d0
Merge branch 'master' into weakref_callback
skinnyBat Feb 19, 2019
e89f8fa
Fix clippy warning
skinnyBat Feb 19, 2019
b6d28cf
Formatting
skinnyBat Feb 19, 2019
350bc30
Move weak_refs attribute into Instance payload
skinnyBat Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix clippy warning
  • Loading branch information
@skinnyBat
skinnyBat committed Feb 19, 2019
commit e89f8fafe55082143b231b79098d0643e2b1c82c
2 changes: 1 addition & 1 deletion vm/src/pyobject.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ impl Drop for PyObjectRef {
// The PyObject is going to be dropped, delete it later when we have access to vm.
// This will error when the tls is destroyed, thus meaning objects won't actually
// be properly destroyed.
if let Err(_) = DELETE_QUEUE.try_with(|q| q.borrow_mut().push_back(self.clone())) {
if DELETE_QUEUE.try_with(|q| q.borrow_mut().push_back(self.clone())).is_err() {
warn!("Object hasn't been cleaned up {:?}.", self);
}
}
Expand Down