Skip to content

Update test_cmd_line from Cpython v3.11.2 #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DimitrisJim merged 5 commits into from
Apr 9, 2023
Merged

Update test_cmd_line from Cpython v3.11.2 #4801

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1862d1d
Update test_cmd_line from Cpython v3.11.2
Masorubka1 Apr 2, 2023
fa26b68
wft
Masorubka1 Apr 2, 2023
e7165e8
fix tests
Masorubka1 Apr 2, 2023
8ec024a
fix windows
Masorubka1 Apr 4, 2023
cf06c25
fix windows tests
Masorubka1 Apr 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix windows
  • Loading branch information
@Masorubka1
Masorubka1 committed Apr 4, 2023
commit 8ec024a8fd84d90fd92b6f5ff388886ea6a39295
2 changes: 2 additions & 0 deletions Lib/test/test_cmd_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,8 @@ def test_stdin_readline(self):
"import sys; print(repr(sys.stdin.readline()))",
b"'abc\\n'")

# TODO: RUSTPYTHON
@unittest.skipIf(sys.platform.startswith('win'), "TODO: RUSTPYTHON windows has \n troubles")
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think other tests are marked TODO: RUSTPYTHON, universal newlines, but I like this description better, as it's a clearer statement of the problem.

Copy link
Copy Markdown
Member

@DimitrisJim DimitrisJim Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this can probably be opened as an issue, seems like it wouldn't be too difficult to fix.

def test_builtin_input(self):
# Issue #11272: check that input() strips newlines ('\n' or '\r\n')
self.check_input(
Expand Down