make adding a single module simpler for interpreter users#4792
Merged
youknowone merged 1 commit intoRustPython:mainfrom Mar 21, 2024
Merged
make adding a single module simpler for interpreter users#4792youknowone merged 1 commit intoRustPython:mainfrom
youknowone merged 1 commit intoRustPython:mainfrom
Conversation
DimitrisJim
reviewed
Mar 30, 2023
| self.init_hooks.push(hook); | ||
| self | ||
| } | ||
| pub fn add_native_module( |
Member
There was a problem hiding this comment.
a good idea to document this one then if users are really interested in it (ideally pointing to an example someplace).
Member
Author
There was a problem hiding this comment.
Thank you for a nice advice, really.
I am sorry that I am currently barely maintaining the project and probably not going to finish it in near future.
I am going to merge this PR not because the advice is less useful but just because we eventually need to finish both the code and document. I had to finish at the moment, probably I shared example to the discord chat.
Member
Author
|
the clippy error is false-positive |
9220b2e to
c65c2ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while looking in discord chat, I found it is hard to add a single module to interpreter