Repository navigation
[Draft] Make builtin method type same as that of builtin function - #4686
Closed
seungha-kim wants to merge 2 commits into
Closed
seungha-kim wants to merge 2 commits into
seungha-kim wants to merge 2 commits into
Conversation
seungha-kim
commented
Mar 13, 2023
Contributor
Author
|
I missed that qualname of PyClassMethod must be considered too. (it is the cause of failing tests) Turning this PR to draft now and will look into PyClassMethod. |
seungha-kim
marked this pull request as draft
March 13, 2023 13:53
seungha-kim
force-pushed
the
builtin-method-type
branch
from
March 14, 2023 10:14
3a98980 to
6c3976f
Compare
Closed
seungha-kim
force-pushed
the
builtin-method-type
branch
from
March 23, 2023 15:03
16a0863 to
ffece09
Compare
youknowone
force-pushed
the
builtin-method-type
branch
from
April 5, 2023 16:07
ffece09 to
ea5e5ee
Compare
youknowone
reviewed
Apr 5, 2023
| zelf: None, | ||
| value: self, | ||
| module: None, | ||
| is_classmethod: false, |
Member
There was a problem hiding this comment.
I am not sure about this field
Member
There was a problem hiding this comment.
ah, i got it. we don't have PyMethodDef. So we cannot avoid it now.
youknowone
force-pushed
the
builtin-method-type
branch
13 times, most recently
from
April 9, 2023 13:56
ca23718 to
b76eb6d
Compare
youknowone
force-pushed
the
builtin-method-type
branch
from
April 24, 2023 19:42
b76eb6d to
2e06739
Compare
Member
|
I made #4873 including this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3100