Skip to content

Update test_baseexception.py from cpython 3.11.2 #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Mar 4, 2023
Merged

Update test_baseexception.py from cpython 3.11.2 #4624

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7b8768
Update test_baseexception.py from cpython 3.11.2
Mar 4, 2023
9c10d4a
Mark failing tests of test_baseexception.
dalinaum Mar 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update test_baseexception.py from cpython 3.11.2
  • Loading branch information
@dalinaum
CPython Developers authored and dalinaum committed Mar 4, 2023
commit a7b8768e56eb7f3a0fa90c8b45d8679c889d06cb
32 changes: 29 additions & 3 deletions Lib/test/test_baseexception.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ def test_inheritance(self):
except TypeError:
pass

inheritance_tree = open(os.path.join(os.path.split(__file__)[0],
'exception_hierarchy.txt'))
inheritance_tree = open(
os.path.join(os.path.split(__file__)[0], 'exception_hierarchy.txt'),
encoding="utf-8")
Comment on lines +33 to +35
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm Mar 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing: since this references a file named exception_hierarchy.txt, it would make sense if it could also be brought up to date.

Copy link
Copy Markdown
Contributor Author

@dalinaum dalinaum Mar 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I uploaded it as a PR #4627.

try:
superclass_name = inheritance_tree.readline().rstrip()
try:
Expand All @@ -43,7 +44,7 @@ def test_inheritance(self):
last_depth = 0
for exc_line in inheritance_tree:
exc_line = exc_line.rstrip()
depth = exc_line.rindex('-')
depth = exc_line.rindex('─')
exc_name = exc_line[depth+2:] # Slice past space
if '(' in exc_name:
paren_index = exc_name.index('(')
Expand Down Expand Up @@ -117,6 +118,31 @@ def test_interface_no_arg(self):
[repr(exc), exc.__class__.__name__ + '()'])
self.interface_test_driver(results)

def test_setstate_refcount_no_crash(self):
# gh-97591: Acquire strong reference before calling tp_hash slot
# in PyObject_SetAttr.
import gc
d = {}
class HashThisKeyWillClearTheDict(str):
def __hash__(self) -> int:
d.clear()
return super().__hash__()
class Value(str):
pass
exc = Exception()

d[HashThisKeyWillClearTheDict()] = Value() # refcount of Value() is 1 now

# Exception.__setstate__ should aquire a strong reference of key and
# value in the dict. Otherwise, Value()'s refcount would go below
# zero in the tp_hash call in PyObject_SetAttr(), and it would cause
# crash in GC.
exc.__setstate__(d) # __hash__() is called again here, clearing the dict.

# This GC would crash if the refcount of Value() goes below zero.
gc.collect()


class UsageTests(unittest.TestCase):

"""Test usage of exceptions"""
Expand Down