Skip to content

Fixed several clippy warnings #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
windelbouwman merged 18 commits into from
Feb 12, 2019
Merged

Fixed several clippy warnings #448

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d86ffc4
Fixed the redundant_field_names clippy warnings
ZapAnton Feb 12, 2019
0d1b85a
Fixed the collapsible_if clippy warning
ZapAnton Feb 12, 2019
606ddd2
Fixed the needless_return clippy warnings
ZapAnton Feb 12, 2019
00cfa47
Fixed the should_implement_trait clippy warning
ZapAnton Feb 12, 2019
8b6d0b3
Fixed the op_ref clippy warning
ZapAnton Feb 12, 2019
6656916
Fixed the redundant_closure clippy warning
ZapAnton Feb 12, 2019
9144109
Fixed the useless_vec clippy warning
ZapAnton Feb 12, 2019
050bf45
Fixed the into_iter_on_ref clippy warning
ZapAnton Feb 12, 2019
45b9ef9
Fixed the op_ref clippy warnings
ZapAnton Feb 12, 2019
5fe3735
Fixed the match_bool clippy warning
ZapAnton Feb 12, 2019
291dba6
Fixed the toplevel_ref_arg clippy warning
ZapAnton Feb 12, 2019
3893098
Fixed the redundant_pattern_matching clippy warning
ZapAnton Feb 12, 2019
206ccc5
Fixed the len_without_is_empty clippy warning
ZapAnton Feb 12, 2019
ef65612
Fixed the clone_double_ref clippy warning
ZapAnton Feb 12, 2019
a0f1f51
Fixed the useless_asref clippy warnings
ZapAnton Feb 12, 2019
e8467c3
Fixed the redundant_closure clippy warning
ZapAnton Feb 12, 2019
08d767b
Fixed the unnecessary_mut_passed clippy warning
ZapAnton Feb 12, 2019
604883d
Fixed the len_zero clippy warning
ZapAnton Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed the needless_return clippy warnings
  • Loading branch information
@ZapAnton
ZapAnton committed Feb 12, 2019
commit 606ddd221669bf874bb70d30e746860364eeeadf
20 changes: 10 additions & 10 deletions vm/src/obj/objset.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,48 +180,48 @@ pub fn set_contains(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
}

fn set_eq(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
return set_compare_inner(
set_compare_inner(
vm,
args,
&|zelf: usize, other: usize| -> bool { zelf != other },
false,
);
)
}

fn set_ge(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
return set_compare_inner(
set_compare_inner(
vm,
args,
&|zelf: usize, other: usize| -> bool { zelf < other },
false,
);
)
}

fn set_gt(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
return set_compare_inner(
set_compare_inner(
vm,
args,
&|zelf: usize, other: usize| -> bool { zelf <= other },
false,
);
)
}

fn set_le(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
return set_compare_inner(
set_compare_inner(
vm,
args,
&|zelf: usize, other: usize| -> bool { zelf < other },
true,
);
)
}

fn set_lt(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
return set_compare_inner(
set_compare_inner(
vm,
args,
&|zelf: usize, other: usize| -> bool { zelf <= other },
true,
);
)
}

fn set_compare_inner(
Expand Down