Skip to content

Add object.{__lt__, __le__, __gt__, __gt__} #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
windelbouwman merged 4 commits into from
Feb 12, 2019
Merged

Add object.{__lt__, __le__, __gt__, __gt__} #424

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0887b55
Add object.{__lt__, __le__, __gt__, __gt__}
janczer Feb 12, 2019
1ff1bcd
Fix the call __gt__
janczer Feb 12, 2019
9601673
Fix the reflections of methods lt, le, gt, ge
janczer Feb 12, 2019
9277e67
Add not_implemented to float.{__le__, __gt__, __ge__}
janczer Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the call __gt__
  • Loading branch information
@janczer
janczer committed Feb 12, 2019
commit 1ff1bcda6ba70f8bd63fcebc137fd91d21242e2d
4 changes: 2 additions & 2 deletions vm/src/builtins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ fn builtin_max(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
} else {
y.clone()
};
let order = vm.call_method(&x_key, "__gt__", vec![y_key.clone()])?;
let order = vm._gt(x_key.clone(), y_key.clone())?;

if !objbool::get_value(&order) {
x = y.clone();
Expand Down Expand Up @@ -471,7 +471,7 @@ fn builtin_min(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
} else {
y.clone()
};
let order = vm.call_method(&x_key, "__gt__", vec![y_key.clone()])?;
let order = vm._gt(x_key.clone(), y_key.clone())?;

if objbool::get_value(&order) {
x = y.clone();
Expand Down