Skip to content

Add _socket constants from CPython 3.10 #3840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Jul 6, 2022
Merged

Add _socket constants from CPython 3.10 #3840

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca90bf3
Add `_socket` constants from CPython 3.10
fanninpm Jul 4, 2022
4e87250
Fix compilation errors on macOS and Windows
fanninpm Jul 4, 2022
97db885
Resolve ambiguous imports on Windows
fanninpm Jul 4, 2022
92f790e
Mark erroring/failing tests
fanninpm Jul 5, 2022
b39263d
Mark erroring test on Windows
fanninpm Jul 5, 2022
0b1a542
Unmark passing test on macOS and Windows
fanninpm Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Unmark passing test on macOS and Windows
  • Loading branch information
@fanninpm
fanninpm committed Jul 5, 2022
commit 0b1a54220eeb0508f51ef039cb1cd2b9ae3390d9
6 changes: 4 additions & 2 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1719,8 +1719,6 @@ def test_str_for_enums(self):
self.assertEqual(str(s.family), 'AddressFamily.AF_INET')
self.assertEqual(str(s.type), 'SocketKind.SOCK_STREAM')

# TODO: RUSTPYTHON, AssertionError: 526337 != <SocketKind.SOCK_STREAM: 1>
@unittest.expectedFailure
def test_socket_consistent_sock_type(self):
SOCK_NONBLOCK = getattr(socket, 'SOCK_NONBLOCK', 0)
SOCK_CLOEXEC = getattr(socket, 'SOCK_CLOEXEC', 0)
Expand All @@ -1737,6 +1735,10 @@ def test_socket_consistent_sock_type(self):
s.setblocking(False)
self.assertEqual(s.type, socket.SOCK_STREAM)

# TODO: RUSTPYTHON, AssertionError: 526337 != <SocketKind.SOCK_STREAM: 1>
if sys.platform == "linux":
test_socket_consistent_sock_type = unittest.expectedFailure(test_socket_consistent_sock_type)

def test_unknown_socket_family_repr(self):
# Test that when created with a family that's not one of the known
# AF_*/SOCK_* constants, socket.family just returns the number.
Expand Down