derive __text_signature__ from method definition - #2923
Conversation
7d9bb27 to
374f263
Compare
|
In general I think this is a step in the right direction. Many builtins will be covered and those that aren't covered can just have the signature placed there manually (i.e this step would be nice if it was made only if a signature hasnt been specified already). Another small detail on this: it now requires us to try and follow the names used in CPython more closely (though I'm sure most functions/methods already do that). |
be8790a to
65dd911
Compare
|
Yes, that will be a new concern for argument names. Already generated |
65dd911 to
5ee9719
Compare
| /// object() | ||
| /// -- | ||
| /// |
There was a problem hiding this comment.
As I understood, ImplItem<Item> for MethodItem will not affect at class documentation ClassItem. When I executed object.__text_signature__, it returns None. I guess these changes will revert some resolved problems again (#2732 (comment), #2623 (comment)).
5ee9719 to
da16618
Compare
This PR is not perfectly solving the issue but showing the first step to go. I think we can keep the signature and actual function better from this way.
improving #2904 in automated way
cc @moreal