Skip to content

Adds __rmul__ to collections.deque #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DimitrisJim merged 4 commits into from
Aug 11, 2021
Merged

Adds __rmul__ to collections.deque #2844

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98a075f
Adds `__rmul__` to `collections.deque`, refs #2834
sobolevn Aug 11, 2021
7b180a7
Fixes tests and overflow error
sobolevn Aug 11, 2021
53cec4f
Refactor
sobolevn Aug 11, 2021
62972d6
Refactor
sobolevn Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Refactor
  • Loading branch information
@sobolevn
sobolevn committed Aug 11, 2021
commit 62972d6dfa259e7b8e35f205c29a4ccac3cd5de8
3 changes: 2 additions & 1 deletion vm/src/stdlib/collections.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,9 @@ mod _collections {
let skipped = self
.maxlen
.load()
.map(|maxlen| mul.len().wrapping_sub(maxlen))
.and_then(|maxlen| mul.len().checked_sub(maxlen))
.unwrap_or(0);

let deque = mul.skip(skipped).cloned().collect();
PyDeque {
deque: PyRwLock::new(deque),
Expand Down