Final demo improvements#245
Merged
windelbouwman merged 29 commits intoRustPython:masterfrom Dec 29, 2018
Merged
Conversation
This included changing RustObjectKind::RustFunction.function to be a `Box<Fn()>` instead of a `fn()` to support closures.
…l/wasm-pack-plugin Also change travis deploy to use new demo directory.
Contributor
|
Thank you for your contribution! |
Member
Author
|
Thanks for merging this! One last thing, would you mind pushing to the release branch? Thanks! Also, sorry for not squashing the commits, I was following a StackOverflow post and I thought what they suggested would do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final stage (in theory) of #238. This is a new branch split off of master just now, so no merge conflicts. I'd still like to add a few™ more things (
Cargo.tomlfields maybe), but then this should be done.