Serialize entire frozen hashmap to bytes#2403
Merged
Merged
Conversation
d619f9f to
f89a8fa
Compare
youknowone
approved these changes
Jan 29, 2021
| use super::*; | ||
| use bincode::{options, Options}; | ||
| use std::convert::TryInto; | ||
| use std::io::{self}; |
f89a8fa to
58503cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So instead of
hashmap! { "a" => decode(b"....."), "b" => decode(b"......") }, it's justdecode(b"<map>")release binary sizes:
My hunch on this was that putting all the data in the same buffer gives lz4 more opportunity to deduplicate, and I'm pretty sure that's what made the difference in binary size.