Skip to content

Implement most string module constants#235

Merged
windelbouwman merged 1 commit intoRustPython:masterfrom
xrmx:stringconstants
Dec 29, 2018
Merged

Implement most string module constants#235
windelbouwman merged 1 commit intoRustPython:masterfrom
xrmx:stringconstants

Conversation

@xrmx
Copy link
Copy Markdown
Contributor

@xrmx xrmx commented Dec 20, 2018

I'm a rust newbie please review :)

@xrmx
Copy link
Copy Markdown
Contributor Author

xrmx commented Dec 20, 2018

BTW tests does not work for me, first one needs to install pytest, pip install pytest inside the pipenv shell worked fine but then:

ImportError while importing test module '/home/rm/src/RustPython/tests/test_snippets.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test_snippets.py:15: in <module>
    import compile_code
compile_code.py:1: in <module>
    import bytecode
E   ModuleNotFoundError: No module named 'bytecode'

@xrmx xrmx force-pushed the stringconstants branch 2 times, most recently from 74b0733 to 56604f9 Compare December 21, 2018 09:38
@xrmx xrmx changed the title Implement string module constants WIP Implement string module constants Dec 21, 2018
@xrmx
Copy link
Copy Markdown
Contributor Author

xrmx commented Dec 21, 2018

So tests fails because some string.whitespace entries gets interpreted, will update once i have a fix

@windelbouwman
Copy link
Copy Markdown
Contributor

Nice job! If you cannot find a solution for the whitespaces, you can comment out the problematic cases and try to fix them in a next PR.

@xrmx xrmx force-pushed the stringconstants branch 2 times, most recently from 6dddc18 to 7d92c56 Compare December 27, 2018 22:47
whitespace and thus printable are excluded because i haven't found
a way to make tests pass.
@xrmx
Copy link
Copy Markdown
Contributor Author

xrmx commented Dec 27, 2018

@windelbouwman ok, rebased and commented the code not working.

@xrmx xrmx changed the title WIP Implement string module constants Implement most string module constants Dec 27, 2018
@windelbouwman
Copy link
Copy Markdown
Contributor

@xrmx thank you for your contribution!

@windelbouwman windelbouwman merged commit d508d13 into RustPython:master Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants