Implement most string module constants#235
Merged
windelbouwman merged 1 commit intoRustPython:masterfrom Dec 29, 2018
Merged
Conversation
Contributor
Author
|
BTW tests does not work for me, first one needs to install pytest, |
74b0733 to
56604f9
Compare
Contributor
Author
|
So tests fails because some string.whitespace entries gets interpreted, will update once i have a fix |
Contributor
|
Nice job! If you cannot find a solution for the whitespaces, you can comment out the problematic cases and try to fix them in a next PR. |
6dddc18 to
7d92c56
Compare
whitespace and thus printable are excluded because i haven't found a way to make tests pass.
7d92c56 to
e4ca165
Compare
Contributor
Author
|
@windelbouwman ok, rebased and commented the code not working. |
Contributor
|
@xrmx thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a rust newbie please review :)