Skip to content

Change sum and round to take keywords#2341

Closed
carbotaniuman wants to merge 3 commits into
RustPython:masterfrom
carbotaniuman:test
Closed

Change sum and round to take keywords#2341
carbotaniuman wants to merge 3 commits into
RustPython:masterfrom
carbotaniuman:test

Conversation

@carbotaniuman
Copy link
Copy Markdown
Contributor

No description provided.

@carbotaniuman
Copy link
Copy Markdown
Contributor Author

Another clippy issue?

@coolreader18
Copy link
Copy Markdown
Member

I think this one makes sense; there isn't any difference between if x { return } if y { return } and if x { return } else if y { return }, and the second version is a bit clearer to read.

@youknowone
Copy link
Copy Markdown
Member

If this is one of the typical match_class case, using it will be good.

coolreader18 added a commit that referenced this pull request Nov 24, 2020
Change sum and round to take keywords
@coolreader18
Copy link
Copy Markdown
Member

Merged it manually to fix conflict. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants