Replace FuncArgs.insert with prepend_arg, optimize check_signals#2339
Merged
Conversation
youknowone
approved these changes
Nov 24, 2020
youknowone
reviewed
Nov 24, 2020
|
|
||
| trigger_signals(&signal_handlers.borrow(), vm) | ||
| } | ||
| #[inline(never)] |
Member
There was a problem hiding this comment.
How about cold attribute? this is a question instead of suggestion because i haven't seen any actual usage of cold yet. https://doc.rust-lang.org/reference/attributes/codegen.html
Member
Author
There was a problem hiding this comment.
That sounds good, I was thinking that it really isn't that exceptional of a case, but given that it is (possibly) called for every instruction execution it would make sense to signal that it should very rarely ever happen.
6f23293 to
8ff7a52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./rustpython-norm benchmarks/pystone.py 50000./rustpython-opt benchmarks/pystone.py 50000