Split the ast from the parser, remove compiler dep on parser#2320
Merged
Conversation
3b7c20c to
57f60cb
Compare
Member
Author
|
Maybe something like |
a562695 to
70907ba
Compare
youknowone
approved these changes
Nov 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should improve build times, since now the compiler and the parser can build in parallel, and I think it also just separates concerns a bit more -- the core compiler just needs an AST to be able to do its job, and it's up to the user to provide that. I was thinking of making another crate that would essentially just be
vm::compile, but I wasn't sure what to call it or if would even be necessary, since I'm not sure how many uses there would be for an external crate to use the compiler. Although, I gave pyckitup the ability to compile rustpython bytecode, so maybe it would be worth looking into to have that be another crate.