Skip to content

Try skipping caching on macos#2314

Merged
youknowone merged 10 commits into
masterfrom
coolreader18/no-cache-mac
Nov 6, 2020
Merged

Try skipping caching on macos#2314
youknowone merged 10 commits into
masterfrom
coolreader18/no-cache-mac

Conversation

@coolreader18
Copy link
Copy Markdown
Member

@coolreader18 coolreader18 commented Oct 28, 2020

No description provided.

@coolreader18 coolreader18 force-pushed the coolreader18/no-cache-mac branch 3 times, most recently from dd01406 to 5058a51 Compare October 29, 2020 02:14
youknowone
youknowone requested changes Oct 29, 2020
View reviewed changes
Comment thread .github/workflows/ci.yaml Outdated
target/release/rustpython -m test -v -x
test_argparse test_json test_bytes test_bytearray test_long test_unicode test_array
test_asyncgen test_list test_complex test_json test_set test_dis test_calendar
test_importlib
Copy link
Copy Markdown
Member

@youknowone youknowone Oct 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

importlib depends on filesystem. I think this is better to be not skipped.

Copy link
Copy Markdown
Member Author

@coolreader18 coolreader18 Oct 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I unskip it for windows as well? I thought the same, but it seemed like it took a while and I figured that if windows skipped it then it was probably fine

Copy link
Copy Markdown
Member

@youknowone youknowone Oct 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so if possible. The winodws tests with -x were failing at the time I added it.

@coolreader18 coolreader18 force-pushed the coolreader18/no-cache-mac branch 3 times, most recently from acc8c43 to 9a8a10d Compare November 2, 2020 04:26
@coolreader18 coolreader18 force-pushed the coolreader18/no-cache-mac branch from 9a8a10d to 62241b6 Compare November 2, 2020 18:50
@coolreader18 coolreader18 force-pushed the coolreader18/no-cache-mac branch 6 times, most recently from e4b9328 to 34bd00a Compare November 3, 2020 02:25
@coolreader18 coolreader18 force-pushed the coolreader18/no-cache-mac branch from 34bd00a to e4f446e Compare November 3, 2020 04:50
@coolreader18
Copy link
Copy Markdown
Member Author

coolreader18 commented Nov 3, 2020

@youknowone I wasn't able to get windows test_importlib working; it completely succeeds on my machine, but on ci there's something weird with rmtree failing because it wasn't able to remove all the files in a directory, I think? Which might be because there's still an open handle to one of the files for some reason, and windows can't unlink a file until the handle's closed. Also, it's always only 1 of the files that doesn't get removed, for some reason. e.g.:

test_lacking_parent (test.test_importlib.source.test_file_loader.SimpleTest) ... rmtree unlinking dir D:\a\RustPython\RustPython\tmp\tmpq16syujf\_pkg
rmtree unlinking D:\a\RustPython\RustPython\tmp\tmpq16syujf\_pkg\mod.py
rmtree unlinking D:\a\RustPython\RustPython\tmp\tmpq16syujf\_pkg\__init__.py
rmtree unlinking dir D:\a\RustPython\RustPython\tmp\tmpq16syujf\_pkg\__pycache__
rmtree unlinking D:\a\RustPython\RustPython\tmp\tmpq16syujf\_pkg\__pycache__\mod.rustpython-01.pyc
ooh there's still ['mod.py']
D:\a\RustPython\RustPython\vm\pylib-crate\Lib\test\support\__init__.py:414: RuntimeWarning: tests may fail, delete still pending for D:\a\RustPython\RustPython\tmp\tmpq16syujf\_pkg
  _waitfor(_rmtree_inner, path, waitall=True)
OSError: The directory is not empty. (os error 145)
re-run rmdir('D:\\a\\RustPython\\RustPython\\tmp\\tmpq16syujf\\_pkg',)
ERROR

ci run

@youknowone youknowone merged commit ac4e5b8 into master Nov 6, 2020
@youknowone youknowone deleted the coolreader18/no-cache-mac branch November 6, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coolreader18 @youknowone