Switch to using parking_lot::Mutex instead of std::sync::Mutex#1943
Switch to using parking_lot::Mutex instead of std::sync::Mutex#1943youknowone merged 1 commit intomasterfrom
Conversation
|
I think we should do such a big change only after we are using a published stable release of |
|
That sounds good to me, I can put this on hold till then. |
5faa2ac to
ebab829
Compare
|
This gave about an 11% speedup for me running the test suite (though it's like 8-9 minutes so I didn't run hyperfine or anything yet) and a 4%-8% speedup for the benchmarks in the benchmarks directory. |
|
Actually, I've been thinking about something for a while that this would be a good change to make with: we could make a wrapper type around Edit: if I do do this, it will be in a separate PR, it'd be best to make a batch change like this one on its own, I think. |
|
@youknowone could you review this? |
All of the benefits of
parking_lot::Mutexover the std one are listed in itsreadme, but the ones that apply
to us are copied here: