Skip to content

Implement _random.Random #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coolreader18 merged 7 commits into from
Feb 5, 2020
Merged

Implement _random.Random #1731

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8a3fb40
Implement `random` module
malkoG Oct 26, 2019
908abef
Apply code review for test snippet
malkoG Dec 14, 2019
a20b6bf
Implement _random using the MT19937 algorithm
coolreader18 Feb 1, 2020
2fd9eb9
Add random.py from CPython 3.6
coolreader18 Feb 1, 2020
b40dcb7
Use random.Random in tempfile
coolreader18 Feb 1, 2020
a762bf8
Move gen_res53 to mersenne.rs
coolreader18 Feb 4, 2020
9abb258
Fix clippy warnings
coolreader18 Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move gen_res53 to mersenne.rs
  • Loading branch information
@coolreader18
coolreader18 committed Feb 4, 2020
commit a762bf89d97fab01b579ba41fa34969d7d38e6ae
11 changes: 1 addition & 10 deletions vm/src/stdlib/random.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ impl PyRandom {

#[pymethod]
fn random(&self) -> f64 {
gen_res53(&mut *self.rng.borrow_mut())
mersenne::gen_res53(&mut *self.rng.borrow_mut())
}

#[pymethod]
Expand Down Expand Up @@ -127,12 +127,3 @@ pub fn make_module(vm: &VirtualMachine) -> PyObjectRef {
"Random" => PyRandom::make_class(ctx),
})
}

// taken from the translated mersenne twister
/* generates a random number on [0,1) with 53-bit resolution*/
fn gen_res53<R: RngCore>(rng: &mut R) -> f64 {
let a = rng.next_u32() >> 5;
let b = rng.next_u32() >> 6;
(a as f64 * 67108864.0 + b as f64) * (1.0 / 9007199254740992.0)
}
/* These real versions are due to Isaku Wada, 2002/01/09 added */
8 changes: 8 additions & 0 deletions vm/src/stdlib/random/mersenne.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,14 @@ impl MT19937 {
}
}

/* generates a random number on [0,1) with 53-bit resolution*/
pub fn gen_res53<R: rand::RngCore>(rng: &mut R) -> f64 {
let a = rng.next_u32() >> 5;
let b = rng.next_u32() >> 6;
(a as f64 * 67108864.0 + b as f64) * (1.0 / 9007199254740992.0)
}
/* These real versions are due to Isaku Wada, 2002/01/09 added */

impl rand::RngCore for MT19937 {
fn next_u32(&mut self) -> u32 {
self.gen_u32()
Expand Down