Repository navigation
fix line continuation parsing - #1698
Merged
Merged
Conversation
coolreader18
approved these changes
Jan 24, 2020
coolreader18
left a comment
Member
There was a problem hiding this comment.
Nice! I noticed this too, but I wasn't sure what the specific cause was or how to fix it. This'll make debugging errors that originate in stdlib code a lot easier.
palaviv
force-pushed
the
fix-line-continue
branch
from
January 24, 2020 19:50
d5b0961 to
ad4beab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when we had a line continuation all lines numbers after were shifted by one. For example:
Would say the exception was in line 2 instead of 3.