Repository navigation
Demo improvements - #1675
Demo improvements#1675
Conversation
a6e7835 to
6feb0d7
Compare
| ) from ex | ||
|
|
||
|
|
||
| from selenium import webdriver |
There was a problem hiding this comment.
How about splitting the conftest into two files. One for the server setup and one for the selenium?
There was a problem hiding this comment.
I think it's good to have it in one file, because ideally the connection between the server and the wdriver fixture should be an "implementation detail" (whatever that means for test infrastructure) -- essentially, the http server is just a means to an end of loading the demo into the webdriver.
| server_proc = None | ||
|
|
||
|
|
||
| def pytest_sessionstart(session): |
There was a problem hiding this comment.
How about changing this to be a module scope fixture?
There was a problem hiding this comment.
Then the server would have to be started and stopped for every test, and given that a simple http server is stateless anyway, I don't think it makes much of a difference.
async/awaitexecutor built on the browser event loop.index.jsandmain.jsinto one, to avoid the page being essentially without content while the wasm payload loads.rp.pyExecandrp.pyExecSingleto the "documentation".pipenv run pytestwithout having to mess with the npm commands.driverfixture, move it towdriverinconftest.py.