Implement zlib module#1243
Merged
Merged
Conversation
+ Implement following functions: * zlib.compress * zlib.decompress * zlib.crc32 * zlib.adler32 + Add compression level constants
| }; | ||
| } | ||
|
|
||
| checksum_fn!( |
Contributor
There was a problem hiding this comment.
The macro is used twice, so I would suggest to simply write out the two methods for readability. It's about the same amount on lines, but is somewhat easier to read. What do you think?
Contributor
Author
There was a problem hiding this comment.
Ok, at the first time i had done it with PyFuncArgs and arg_check! - it was much longer then. I'll rewrite it
Get rid of checksum_fn macro
| for text in compressed_lorem_list: | ||
| assert zlib.decompress(text) == lorem | ||
|
|
||
| assert_raises(zlib.error, lambda: zlib.compress(b"123", -40)) |
Contributor
There was a problem hiding this comment.
Just a minor though, I find this
with assertRaises(zlib.error):
zlib.compress(b"123", -40)somewhat easier to read. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I implemented following methods from
zlibmodule:zlib.compresszlib.decompresszlib.crc32zlib.adler32