Improve the situation regarding boolean operations.#1234
Merged
Conversation
coolreader18
approved these changes
Aug 11, 2019
Member
coolreader18
left a comment
There was a problem hiding this comment.
Nice! Good job on figuring this out 😃
| true_label: Option<Label>, | ||
| false_label: Option<Label>, | ||
| context: EvalContext, | ||
| condition: bool, |
Member
There was a problem hiding this comment.
I'd recommend moving condition to the first argument and removing the second underscore in the function name so it can read better, e.g. you can see compile_jumpif(true, ...) compiles a JumpIfTrue.
Contributor
Author
There was a problem hiding this comment.
The way I intended this to read was: compile_jump_if(expression, true, target) means: Jump if the expression is true to target.
Contributor
Author
There was a problem hiding this comment.
I'll leave this for now like it is. Thanks for the idea!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the boolean short circuit logic in line with cpython and micropython.