Skip to content

gh-1212: Fix scope_for_name to catch NameError properly#1232

Merged
windelbouwman merged 1 commit into
RustPython:masterfrom
corona10:gh-1212
Aug 12, 2019
Merged

gh-1212: Fix scope_for_name to catch NameError properly#1232
windelbouwman merged 1 commit into
RustPython:masterfrom
corona10:gh-1212

Conversation

@corona10
Copy link
Copy Markdown
Contributor

fix: #1212

@corona10 corona10 force-pushed the gh-1212 branch 3 times, most recently from 7e283a3 to 1eca3c4 Compare August 11, 2019 15:59
@corona10 corona10 changed the title gh-1212: Fix scope_for_name to catch NameError properly [WIP} gh-1212: Fix scope_for_name to catch NameError properly Aug 11, 2019
@corona10 corona10 changed the title [WIP} gh-1212: Fix scope_for_name to catch NameError properly [WIP] gh-1212: Fix scope_for_name to catch NameError properly Aug 11, 2019
@corona10 corona10 changed the title [WIP] gh-1212: Fix scope_for_name to catch NameError properly gh-1212: Fix scope_for_name to catch NameError properly Aug 11, 2019
@corona10
Copy link
Copy Markdown
Contributor Author

@windelbouwman
Please take a look.
The CI test failure looks like not related to this patch.
(I found that #1231 is also failed with the same test)

Comment thread compiler/src/compile.rs
Comment thread bytecode/src/bytecode.rs Outdated
@windelbouwman
Copy link
Copy Markdown
Contributor

The build might be fixed on the master branch. If you merge the master branch again into your own branch, the build might succeed.

@corona10 corona10 force-pushed the gh-1212 branch 2 times, most recently from 3a5221d to f31f63a Compare August 12, 2019 01:10
@corona10
Copy link
Copy Markdown
Contributor Author

@windelbouwman
Thanks for the review! Please take a look

@windelbouwman windelbouwman merged commit 752ac1d into RustPython:master Aug 12, 2019
@corona10 corona10 deleted the gh-1212 branch August 12, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Found NameError case that is not properly handled

2 participants