Fix a few WASI lints (#8457)

joshuamegnauth54 · web-flow · commit 9bab06cb7777 · 2026-08-08T02:23:05.000+09:00
I left one lint (a clippy deny) unfixed because it's a lot more
involved, so I'll work on it in a different patch.
diff --git a/crates/vm/src/frame.rs b/crates/vm/src/frame.rs
@@ -3046,6 +3046,7 @@ impl ExecutingFrame<'_> {
                 }
             }
 
+            #[cfg_attr(not(feature = "threading"), allow(clippy::collapsible_if))]
             if vm.eval_breaker_tripped() {
                 if let Err(exception) = vm.check_signals() {
                     #[cold]
diff --git a/crates/vm/src/gc_state.rs b/crates/vm/src/gc_state.rs
@@ -11,8 +11,8 @@ use core::sync::atomic::{AtomicBool, AtomicU32, AtomicUsize, Ordering};
 use std::collections::HashSet;
 
 fn elapsed_secs(
-    #[cfg(target_arch = "wasm32")] _start: &(),
-    #[cfg(not(target_arch = "wasm32"))] start: &std::time::Instant,
+    #[cfg(target_arch = "wasm32")] _start: (),
+    #[cfg(not(target_arch = "wasm32"))] start: std::time::Instant,
 ) -> f64 {
     cfg_select! {
         target_arch = "wasm32" => 0.0,
@@ -528,7 +528,7 @@ impl GcState {
                 self.generations[i].count.store(0, Ordering::SeqCst);
             }
 
-            let duration = elapsed_secs(&start_time);
+            let duration = elapsed_secs(start_time);
 
             self.generations[generation].update_stats(0, 0, 0, duration);
             return CollectResult {
@@ -704,7 +704,7 @@ impl GcState {
                 self.generations[i].count.store(0, Ordering::SeqCst);
             }
 
-            let duration = elapsed_secs(&start_time);
+            let duration = elapsed_secs(start_time);
 
             self.generations[generation].update_stats(0, 0, candidates, duration);
             return CollectResult {
@@ -727,7 +727,7 @@ impl GcState {
                 self.generations[i].count.store(0, Ordering::SeqCst);
             }
 
-            let duration = elapsed_secs(&start_time);
+            let duration = elapsed_secs(start_time);
 
             self.generations[generation].update_stats(0, 0, candidates, duration);
             return CollectResult {
@@ -953,7 +953,7 @@ impl GcState {
             self.generations[i].count.store(0, Ordering::SeqCst);
         }
 
-        let duration = elapsed_secs(&start_time);
+        let duration = elapsed_secs(start_time);
 
         self.generations[generation].update_stats(collected, 0, candidates, duration);
 
diff --git a/crates/vm/src/stdlib/_signal.rs b/crates/vm/src/stdlib/_signal.rs
@@ -429,6 +429,13 @@ pub(crate) mod _signal {
     }
 
     #[pyfunction]
+    #[cfg_attr(
+        not(any(unix, windows)),
+        expect(
+            clippy::unnecessary_wraps,
+            reason = "WASI does not support signals yet"
+        )
+    )]
     fn valid_signals(vm: &VirtualMachine) -> PyResult {
         use crate::PyPayload;
         use crate::builtins::PySet;
diff --git a/crates/vm/src/stdlib/posix_compat.rs b/crates/vm/src/stdlib/posix_compat.rs
@@ -60,7 +60,7 @@ pub(crate) mod module {
 
     #[allow(dead_code)]
     fn os_unimpl<T>(func: &str, vm: &VirtualMachine) -> PyResult<T> {
-        Err(vm.new_os_error(format!("{} is not supported on this platform", func)))
+        Err(vm.new_os_error(format!("{func} is not supported on this platform")))
     }
 
     pub(crate) fn support_funcs() -> Vec<SupportFunc> {
diff --git a/crates/vm/src/stdlib/time.rs b/crates/vm/src/stdlib/time.rs
@@ -609,6 +609,7 @@ mod decl {
     }
 
     #[pyfunction]
+    #[cfg_attr(not(any(unix, windows)), expect(clippy::unnecessary_wraps,))]
     fn strftime(format: PyStrRef, t: OptionalArg<StructTimeData>, vm: &VirtualMachine) -> PyResult {
         #[cfg(any(unix, windows))]
         {

Original file line number	Diff line number	Diff line change
`@@ -3046,6 +3046,7 @@ impl ExecutingFrame<'_> {`
`3046`	`3046`	`}`
`3047`	`3047`	`}`
`3048`	`3048`
	`3049`	`+ #[cfg_attr(not(feature = "threading"), allow(clippy::collapsible_if))]`
`3049`	`3050`	`if vm.eval_breaker_tripped() {`
`3050`	`3051`	`if let Err(exception) = vm.check_signals() {`
`3051`	`3052`	`#[cold]`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ pub(crate) mod module {`
`60`	`60`
`61`	`61`	`#[allow(dead_code)]`
`62`	`62`	`fn os_unimpl<T>(func: &str, vm: &VirtualMachine) -> PyResult<T> {`
`63`		`- Err(vm.new_os_error(format!("{} is not supported on this platform", func)))`
	`63`	`+ Err(vm.new_os_error(format!("{func} is not supported on this platform")))`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`pub(crate) fn support_funcs() -> Vec<SupportFunc> {`
Original file line number	Diff line number	Diff line change
`@@ -609,6 +609,7 @@ mod decl {`
`609`	`609`	`}`
`610`	`610`
`611`	`611`	`#[pyfunction]`
	`612`	`+ #[cfg_attr(not(any(unix, windows)), expect(clippy::unnecessary_wraps,))]`
`612`	`613`	`fn strftime(format: PyStrRef, t: OptionalArg<StructTimeData>, vm: &VirtualMachine) -> PyResult {`
`613`	`614`	`#[cfg(any(unix, windows))]`
`614`	`615`	`{`